docs: clarify code comments in optimize-missing-deps#7332
Merged
patak-cat merged 7 commits intovitejs:mainfrom May 4, 2022
Merged
docs: clarify code comments in optimize-missing-deps#7332patak-cat merged 7 commits intovitejs:mainfrom
optimize-missing-deps#7332patak-cat merged 7 commits intovitejs:mainfrom
Conversation
ygj6
previously approved these changes
Mar 28, 2022
Member
ygj6
left a comment
There was a problem hiding this comment.
I'm sorry I wrote this confusing note, which contains a stale story about "built-in deps". Your changes are correct to make it clearer, thank you!
In addition, the main purpose of optimize-missing-deps is to test that _registerMissingImport is not triggered during SSR. You can see the reason and my detailed description at #5017 (comment). Hope it helps you understand.
9 tasks
brillout
previously approved these changes
May 3, 2022
Contributor
|
@ygj6 Do you know why the test is failing (https://github.com/vitejs/vite/pull/6698/checks) when externalizing SSR dependencies (#6698)? |
bluwy
reviewed
May 3, 2022
Member
bluwy
left a comment
There was a problem hiding this comment.
Wonder if this description is more concise. I find the current one a bit off 😅
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
This reverts commit 05bd213.
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
benmccann
commented
May 3, 2022
bluwy
reviewed
May 3, 2022
bluwy
approved these changes
May 3, 2022
brillout
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I didn't understand that "missing" meant not discovered. Also, the sentence "this will import missing deps nest built-in deps" seems like it has a typo because it doesn't make sense
Please check that what I've written is correct
Additional context
This test was failing when I was working on another change and I wanted to better understand it
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).