docs: warning for new URL(url, import.meta.url)#7279
Merged
patak-cat merged 2 commits intovitejs:mainfrom Apr 8, 2022
Merged
Conversation
Vite use `es2019` as default target for building and Pre-Bundling which does not support `import.meta.url`.
`import.meta.url` will be transpiled to
```javascript
var import_metaN = {};
new URL(url, import_metaN.url);
```
This will cause a fatal error.
This was referenced Mar 11, 2022
7 tasks
patak-cat
approved these changes
Apr 8, 2022
new URL(url, import.meta.url) because it does not work by default.new URL(url, import.meta.url)
7 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite use
es2019as default esbuild target for building and pre-bundling, which does NOT supportimport.meta.url.new URL(import.meta.url)will be transpiled toThis will cause a fatal error.
Description
fix #5558 and #5270
new URL(url, import.meta.url)pattern does not work by default. Users will get a confusing error after the code is bundled.Additional context
I would recommend vite to upgrade its esbuild config. Even esbuild use es2020 by default.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).