Skip to content

fix: use browserHash for imports from node_modules#7278

Merged
patak-cat merged 1 commit intomainfrom
fix/vitepress-browserhash
Mar 11, 2022
Merged

fix: use browserHash for imports from node_modules#7278
patak-cat merged 1 commit intomainfrom
fix/vitepress-browserhash

Conversation

@patak-cat
Copy link
Member

Description

Fix VitePress.

Revert a change introduced by #6758. See https://github.com/vitejs/vite/pull/6758/files#diff-9b81bb364c02eab9494a7d27a5effc400cacbffd3b8f349c192f890c37bfc83fR609

I wrote in the PR description:

Note: hash is used instead of browserHash for files excluded from optimization. This is unrelated to the PR, but as we need to re-test quite a bit to be able to merge this one, I think we could also check it in. hash only depends on the lock file, but should be enough here AFAICS

browserHash is actually needed here, as hash will be stable after a reload and these files will be stale.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me 👍

@patak-cat patak-cat merged commit 161f8ea into main Mar 11, 2022
@patak-cat patak-cat deleted the fix/vitepress-browserhash branch March 11, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants