fix(ssr): failed ssrLoadModule call throws same error#7177
Merged
patak-cat merged 3 commits intovitejs:mainfrom Apr 30, 2022
Merged
fix(ssr): failed ssrLoadModule call throws same error#7177patak-cat merged 3 commits intovitejs:mainfrom
patak-cat merged 3 commits intovitejs:mainfrom
Conversation
bluwy
reviewed
Mar 5, 2022
Member
bluwy
left a comment
There was a problem hiding this comment.
The fix looks good to me, but I think the tests should be in packages/vite/src/node/ssr/__tests__/ssrModuleLoader.spec.ts to group the SSR tests.
Contributor
Author
|
okay, done. |
bluwy
previously approved these changes
Mar 5, 2022
Contributor
|
This is super nitpicky but this PR isn't quite in line with the behaviour of Node and browsers. If a module throws an error during instantiation, subsequent imports will throw the same error object: let e1, e2;
try {
await import('./bad.js');
} catch (e) {
e1 = e;
}
try {
await import('./bad.js');
} catch (e) {
e2 = e;
}
assert.equal(e1, e2);With this PR, the module is re-instantiated, and a new error is thrown. I was working on a PR separately, unaware this had already been submitted, and the solution I landed on was this — basically, store the error as |
9 tasks
bluwy
approved these changes
Mar 7, 2022
patak-cat
approved these changes
Apr 30, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #7030
Additional context
Is the new test file in the correct location?
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).