feat: give some logs about browser-external at the pre-bundling period#7115
Closed
jianqi-jin wants to merge 1 commit intovitejs:mainfrom
Closed
feat: give some logs about browser-external at the pre-bundling period#7115jianqi-jin wants to merge 1 commit intovitejs:mainfrom
jianqi-jin wants to merge 1 commit intovitejs:mainfrom
Conversation
Contributor
|
there's already error messages like these in dev mode in browser devtools |
Contributor
Author
|
Yes, it showed in the runtime already. But in the build period, show some thing at the terminal isn't even better? |
Member
|
This PR needs a rebase after some changes to the prebundling flow. Re the PR, I think it may be better to retrieve the externalized list from esbuildDepPlugin by passing a map as a parameter, and have the esbuild plugin mutate it? That way we can prevent the need to update the optimized metadata about it. |
Member
|
Closing due to lack of activity. Thanks for the PR, please open a new one linking to this to keep discussing. I think the proposal by @bluwy is a good idea to improve the implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: give some logs about browser-external at the pre-opt period.
close #7105
Description
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).