Skip to content

feat(legacy): support iife output and merge polyfills with code#7027

Closed
marco-prontera wants to merge 14 commits intovitejs:mainfrom
marco-prontera:feature/7026
Closed

feat(legacy): support iife output and merge polyfills with code#7027
marco-prontera wants to merge 14 commits intovitejs:mainfrom
marco-prontera:feature/7026

Conversation

@marco-prontera
Copy link

@marco-prontera marco-prontera commented Feb 21, 2022

Description

fixes #7026
The goal of this PR is to enhance the legacy of the plugin by adding two parameters to allow users of this plugin to choose between SystemJS or IIFE to generate the legacy version of the bundled code and a parameter to merge the polyfills to the application code.

Additional context

Closes #7026


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Niputi Niputi added p2-nice-to-have Not breaking anything but nice to have (priority) plugin: legacy labels Feb 21, 2022
@bluwy bluwy changed the title feat: Enhance plugin-legacy (#7026) feat(legacy): support iife output and merge polyfills with code Mar 11, 2022
@bluwy bluwy requested a review from aleclarson March 11, 2022 16:17
@marco-prontera
Copy link
Author

Hi @aleclarson, I wanted to ask you if it was possible to verify this PR, please.
I think it is important to minimize dependencies and using SystemJS worries me a little as I don't have the control I need, moreover in some cases the use of SystemJS only adds an overload.
I also think that the balance between cross-browser support and the amount of code could benefit from this because precisely with a configuration we could remove this overload from the output (if not necessary).
At the moment I am forced to use a version locally with these changes proposed in this PR.

Hope for a review soon, sorry for the disturb, and thanks in advance 😉

@aleclarson aleclarson requested review from patak-cat and yyx990803 and removed request for aleclarson April 16, 2022 17:41
@bluwy
Copy link
Member

bluwy commented May 23, 2022

Hi @marco-prontera, just wanted to let you know that we've put this PR in the team discussion board. We'll try to get to it soon. Sorry for the long wait!

@bluwy bluwy added p2-to-be-discussed Enhancement under consideration (priority) and removed p2-nice-to-have Not breaking anything but nice to have (priority) labels May 23, 2022
@marco-prontera
Copy link
Author

Hi @bluwy any news? 😃

@bluwy
Copy link
Member

bluwy commented Jul 14, 2022

Sorry we've been busy with the Vite 3 release. Hoping we can finally take a look at this in the next team meeting 😬

@bluwy
Copy link
Member

bluwy commented Feb 26, 2023

This was discussed in the last meeting. However we decided to not go ahead with this as we prefer to maintain the systemjs only version instead. If you'd like to use this feature, you can fork the plugin and publish it separately. Closing this for now.

@bluwy
Copy link
Member

bluwy commented Feb 26, 2023

This was discussed in the last meeting. However we decided to not go ahead with this as we prefer to maintain the systemjs only version instead. If you'd like to use this feature, you can fork the plugin and publish it separately. Closing this for now.

@bluwy bluwy closed this Feb 26, 2023
@marco-prontera
Copy link
Author

This was discussed in the last meeting. However we decided to not go ahead with this as we prefer to maintain the systemjs only version instead. If you'd like to use this feature, you can fork the plugin and publish it separately. Closing this for now.

I understand, thanks

@marco-prontera marco-prontera deleted the feature/7026 branch February 27, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-to-be-discussed Enhancement under consideration (priority) plugin: legacy

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Enhance plugin-legacy

3 participants