Skip to content

feat: add es.min format for lib mode#6585

Open
Bigfish8 wants to merge 3 commits intovitejs:mainfrom
Bigfish8:esMin-format
Open

feat: add es.min format for lib mode#6585
Bigfish8 wants to merge 3 commits intovitejs:mainfrom
Bigfish8:esMin-format

Conversation

@Bigfish8
Copy link
Contributor

@Bigfish8 Bigfish8 commented Jan 21, 2022 •
edited by Niputi
Loading

Description

resolve: #6555

Additional context

I found there seems no appropriate way for rollup to inject some meta data exposed to plugin.And my implementation might be inappropriate.

If you think the implementation is appropriate, I will add the test case.Otherwise i will change my implementation.

Thanks for you review!

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@poyoho
Copy link
Member

poyoho commented Jan 24, 2022 •
edited
Loading

use fix #6555 to mentioned issues

@abarke
Copy link

abarke commented Feb 16, 2022

@Bigfish8 Would be really nice to have this merged. could you fix the tests? 🙏

This is by far the best and most elegant solution to solve #5167, #5451 and #6079

@Bigfish8
Copy link
Contributor Author

Bigfish8 commented Feb 25, 2022

@abarke have fix the test.
@patak-dev It seems someone needs this PR.Do you have some suggestion on it?

@Niputi Niputi added p2-nice-to-have Not breaking anything but nice to have (priority) and removed needs rebase labels Feb 25, 2022
poyoho
poyoho suggested changes Feb 26, 2022
View reviewed changes
packages/vite/src/node/plugins/esbuild.ts
name: 'vite:esbuild-transpile',
outputOptions(opts) {
// @ts-ignore inject by resolveLibFormat call
if (opts.__vite_lib_minify__) {
Copy link
Member

@poyoho poyoho Feb 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the __vite_lib_minify__ can save into config: ResolvedConfig ?

Copy link
Contributor Author

@Bigfish8 Bigfish8 Mar 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResolvedConfig will include mutiple format,maybe both es and es.min.And save into config: ResolvedConfig making this case not work.

Copy link
Member

@poyoho poyoho Mar 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Record<string, boolean>?

This comment was marked as abuse.

Sign in to view

@abarke
Copy link

abarke commented Jun 22, 2022

Any movement here?

@Junior2Ran
Copy link

Junior2Ran commented Jul 18, 2022

it seems that Build&Test: node-18, ubuntu-latest have been stucked, anybody knows how to restart it?

@abarke
Copy link

abarke commented Dec 9, 2022

Would be great to get this merged!

@abarke abarke mentioned this pull request Dec 9, 2022
Open
4 tasks
@sinedied
Copy link

sinedied commented Dec 9, 2022

@poyoho would it be possible to elaborate a bit on what changes would be needed to get this merged?

It would really be useful to see this PR progressing, and I'm willing to help if needed.

@poyoho
Copy link
Member

poyoho commented Dec 10, 2022

@poyoho would it be possible to elaborate a bit on what changes would be needed to get this merged?

It would really be useful to see this PR progressing, and I'm willing to help if needed.

rebase?

@bluwy bluwy mentioned this pull request Apr 1, 2023
Closed
4 tasks
@Merieli
Copy link

Merieli commented Apr 6, 2023

I need this, how can I help?

@siarheipashkevich
Copy link

siarheipashkevich commented Oct 26, 2023

Any updates?

@Sec-ant
Copy link

Sec-ant commented Nov 2, 2023

Is there a workaround before this PR get merged? I'm aware of some custom plugins mentioned in #6555. But it seems none of them can correctly combine sourcemaps?

@btea btea mentioned this pull request Dec 23, 2024
Closed
7 tasks
@dfabulich dfabulich mentioned this pull request May 15, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Junior2Ran Junior2Ran Junior2Ran left review comments

@poyoho poyoho poyoho requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

feat: library mode p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lib mode format: es.min