Skip to content

fix(types): dynamic import in import.meta#6456

Merged
patak-cat merged 1 commit intovitejs:mainfrom
jeffydc:fix/6433
Jan 11, 2022
Merged

fix(types): dynamic import in import.meta#6456
patak-cat merged 1 commit intovitejs:mainfrom
jeffydc:fix/6433

Conversation

@jeffydc
Copy link
Contributor

@jeffydc jeffydc commented Jan 11, 2022 •
edited
Loading

ref #6433

Description

import AssertOptions dynamically in importMeta.d.ts

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-cat patak-cat merged commit 5d7b4c3 into vitejs:main Jan 11, 2022
@patak-cat
Copy link
Member

patak-cat commented Jan 11, 2022

Thanks @ydcjeff!

@jeffydc jeffydc deleted the fix/6433 branch January 11, 2022 14:44
@Shinigami92
Copy link
Member

Shinigami92 commented Jan 11, 2022

Nothing wrong with this, but I just want to ask a question 🙂

I thought this is exactly a case why import type exist 🤔
So in emitted file it knows that the import can be fully removed and it was only for TS compile time

yyx990803
yyx990803 reviewed Jan 16, 2022
View reviewed changes
@patak-cat patak-cat mentioned this pull request Jan 16, 2022
Merged
4 tasks
@sapphi-red sapphi-red mentioned this pull request Sep 2, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yyx990803 yyx990803 yyx990803 left review comments

@patak-cat patak-cat patak-cat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeffydc @patak-cat @Shinigami92 @yyx990803