fix: exclude acorn.js from node bundle#6141
Closed
TrySound wants to merge 1 commit intovitejs:mainfrom
Closed
Conversation
I found vite has bundled both acorn.mjs and acorn.js. Plugins use it as fallback when parser instance is not passed.
patak-cat
approved these changes
Dec 16, 2021
Member
|
Hmm, this would require |
Contributor
Author
|
@yyx990803 Not really. See https://github.com/acornjs/acorn-class-fields/blob/master/index.js#L6 Acorn already passes own instance when invoking plugins. We don't need to resolve import in plugins. https://github.com/acornjs/acorn/blob/master/acorn/src/index.js#L56 |
Member
|
Ah I see. So the runtime |
Member
|
Let's merge this one once we start the 2.8 beta period |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found vite has bundled both acorn.mjs and acorn.js.
Plugins use it as fallback when parser instance is not passed.
du -ck dist/nodebefore: 12260 kB
after: 11612 kB
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).