Skip to content

fix(ssr): prefer CJS but still allow ESM entries#5662

Merged
patak-cat merged 6 commits intovitejs:mainfrom
aleclarson:fix/ssr-node-resolve
Nov 13, 2021
Merged

fix(ssr): prefer CJS but still allow ESM entries#5662
patak-cat merged 6 commits intovitejs:mainfrom
aleclarson:fix/ssr-node-resolve

Conversation

@aleclarson
Copy link
Contributor

Description

Since ESM support was added in #5197, module resolution should allow pkg.module and the import condition in pkg.exports. This PR fixes that while also still preferring CommonJS, since hookNodeResolve can't intercept ESM->ESM imports (therefore, we want to avoid them if possible).

/cc @benmccann @dominikg @patak-js


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@aleclarson aleclarson added the p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority) label Nov 12, 2021
@patak-cat patak-cat merged commit 72d8925 into vitejs:main Nov 13, 2021
@aleclarson
Copy link
Contributor Author

Ooh I could've removed .jsx too, but oh well

@aleclarson aleclarson deleted the fix/ssr-node-resolve branch February 25, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p5-urgent Fix build-breaking bugs affecting most users, should be released ASAP (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants