fix(ssr): prefer CJS but still allow ESM entries#5662
Merged
patak-cat merged 6 commits intovitejs:mainfrom Nov 13, 2021
Merged
Conversation
benmccann
reviewed
Nov 12, 2021
9 tasks
494e5a3 to
74a5f8b
Compare
44123a7 to
35c65ad
Compare
patak-cat
reviewed
Nov 13, 2021
patak-cat
approved these changes
Nov 13, 2021
Contributor
Author
|
Ooh I could've removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since ESM support was added in #5197, module resolution should allow
pkg.moduleand theimportcondition inpkg.exports. This PR fixes that while also still preferring CommonJS, sincehookNodeResolvecan't intercept ESM->ESM imports (therefore, we want to avoid them if possible)./cc @benmccann @dominikg @patak-js
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).