Skip to content

feat: importing ts files using their corresponding js extesions#5510

Merged
patak-cat merged 4 commits intovitejs:mainfrom
haoqunjiang:ts-extension-alias
Nov 2, 2021
Merged

feat: importing ts files using their corresponding js extesions#5510
patak-cat merged 4 commits intovitejs:mainfrom
haoqunjiang:ts-extension-alias

Conversation

@haoqunjiang
Copy link
Member

Description

To align with tsc default behavior, mentioned in microsoft/TypeScript#46452

Fixes #3040

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Nov 2, 2021
@patak-cat patak-cat changed the title feat: support importing ts files using their corresponding js extesions feat: importing ts files using their corresponding js extesions Nov 2, 2021
@patak-cat patak-cat merged commit 7977e92 into vitejs:main Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Importing a .js typescript resource from a typescript file fails

3 participants