Skip to content

fix: PFX certs not working (closes #4495)#4496

Closed
JohnCampionJr wants to merge 1 commit intovitejs:mainfrom
JohnCampionJr:main
Closed

fix: PFX certs not working (closes #4495)#4496
JohnCampionJr wants to merge 1 commit intovitejs:mainfrom
JohnCampionJr:main

Conversation

@JohnCampionJr
Copy link
Copy Markdown

@JohnCampionJr JohnCampionJr commented Aug 4, 2021 •
edited
Loading

Description

When using PFX files, localhost certs were still being generated.

In addition, Node wanted the passphrase as a buffer.

Fixes #4495

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

fix: PFX certs not working (closes #4495)
026075c 
Was causing pem/key files to be generated.  In addition, Node wanted the passphrase as a buffer.
haoqunjiang
haoqunjiang reviewed Aug 4, 2021
View reviewed changes
@benmccann benmccann mentioned this pull request Aug 7, 2021
Closed
5 tasks
@bluwy bluwy added p2-nice-to-have Not breaking anything but nice to have (priority) needs rebase labels Mar 14, 2022
@sapphi-red
Copy link
Copy Markdown
Member

sapphi-red commented Sep 9, 2022

#4495 (comment)

About passphrase Buffer problem, I think this needs to be confirmed on Node.js side first. It's not clear whether it is a documentation problem or a bug.

@sapphi-red sapphi-red closed this Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@haoqunjiang haoqunjiang haoqunjiang left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PFX Certs are not working

4 participants

@JohnCampionJr @sapphi-red @haoqunjiang @bluwy