Skip to content

fix: upgrade esbuild for esm compatibility#3718

Merged
antfu merged 1 commit intovitejs:mainfrom
lbwa:esbuild-esm
Jun 8, 2021
Merged

fix: upgrade esbuild for esm compatibility#3718
antfu merged 1 commit intovitejs:mainfrom
lbwa:esbuild-esm

Conversation

@lbwa
Copy link
Contributor

@lbwa lbwa commented Jun 8, 2021

fix #3399 fix #3413

Description

esbuild v0.12.7 has added esm marker for specific esm scenario.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the dependencies Pull requests that update a dependency file label Jun 8, 2021
@Niputi
Copy link
Contributor

Niputi commented Jun 8, 2021

should also fix #3617

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught TypeError: Cannot read property 'ToolItem' of undefined without __esModule property when format esm module cause load module error

4 participants