changed dev server command from serve to dev#3125
Closed
ivansieder wants to merge 2 commits intovitejs:mainfrom
ivansieder:patch-3
Closed
changed dev server command from serve to dev#3125ivansieder wants to merge 2 commits intovitejs:mainfrom ivansieder:patch-3
serve to dev#3125ivansieder wants to merge 2 commits intovitejs:mainfrom
ivansieder:patch-3
Conversation
Co-authored-by: Nihal Gonsalves <nihal@nihalgonsalves.com>
nihalgonsalves
approved these changes
Apr 24, 2021
Member
|
Thanks for the PR @ivansieder. I think this doesn't need to be changed though. There is the concept of a 'serve' command. When running vite without a command, it defaults to serve. They are also called commands in the API signatures. |
Member
|
@patak-js This is small issue, but I can see how it's confusing. The create-app templates alias serve to |
Contributor
Author
|
All right, thanks for the feedback @patak-js. It was just unclear to me in that case. Closing this PR in that case. |
Member
|
@nihalgonsalves I think that script should be renamed to 'preview', that is quite confusing. We could also add a line saying that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
changed dev server command from
servetodevWhat is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).