fix: assets ?url import test for windows, fix #2625#2631
Merged
patak-cat merged 3 commits intovitejs:mainfrom Mar 29, 2021
patak-cat:fix/test-assets-url-import
Merged
fix: assets ?url import test for windows, fix #2625#2631patak-cat merged 3 commits intovitejs:mainfrom patak-cat:fix/test-assets-url-import
patak-cat merged 3 commits intovitejs:mainfrom
patak-cat:fix/test-assets-url-import
Conversation
Shinigami92
previously approved these changes
Mar 22, 2021
Member
|
Are you sure that this fixes the test? - data:application/javascript;base64,Y29uc29sZS5sb2coJ2hpJykK
+ data:application/javascript;base64,Y29uc29sZS5sb2coJ2hpJykNCg==
# ^^^^^ |
Member
Author
|
@Shinigami92 it was working, but you are right. There is also padding involved. Added a |
Member
|
I think we can use |
Member
Author
|
We can't because we need the resolved |
Member
|
Ah I see, okay 🙂 |
Shinigami92
approved these changes
Mar 22, 2021
GrygrFlzr
reviewed
Mar 22, 2021
GrygrFlzr
approved these changes
Mar 22, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).What is the purpose of this pull request?
Description
Check #2625, looks like in windows the line end in
foo.jswas\r\n, and in the tests the line end was\n. This test then failed only in Windows.I initially thought of removing the line ends since they are not needed to test the
?urlfeature, but the that is not possible because of prettier. This PR fixes the test in windows by matching with astartsWidthregex instead. I think it is enough for testing this feature.