Skip to content

fix(plugin-legacy): ensure to use the configuration of .browserslistrc#2627

Closed
anncwb wants to merge 1 commit intovitejs:mainfrom
anncwb:fix-issue-2476
Closed

fix(plugin-legacy): ensure to use the configuration of .browserslistrc#2627
anncwb wants to merge 1 commit intovitejs:mainfrom
anncwb:fix-issue-2476

Conversation

@anncwb
Copy link
Contributor

@anncwb anncwb commented Mar 21, 2021

fix #2476

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Description

Additional context

Shinigami92
Shinigami92 reviewed Mar 21, 2021
View reviewed changes
@fwh1990
Copy link

fwh1990 commented Mar 26, 2021

What is going on?

@Shinigami92
Copy link
Member

Shinigami92 commented Mar 26, 2021

@fwh1990 So we have a label review needed
If this is on a PR, someone of the team with write access in this repo need to come along and review it and needs to approve it (or request for changes)

If you want to ask more, feel free to come in the Vite Land Discord Server https://chat.vitejs.dev

We are also happy to invite further folks to our triage team to help us review more and more PRs in parallel 🙂
If you are interested you should nominate yourself here: #2601

@anncwb anncwb closed this May 24, 2021
@fwh1990
Copy link

fwh1990 commented May 25, 2021

Why close this?

@mxpshn mxpshn mentioned this pull request Jul 28, 2021
Closed
3 tasks
@erm1116 erm1116 mentioned this pull request Feb 12, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Shinigami92 Shinigami92 Shinigami92 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plugin: legacy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@vitejs/plugin-legacy does not use browserslistrc

3 participants

@anncwb @fwh1990 @Shinigami92