chore: provide a pr template#2608
Merged
patak-cat merged 9 commits intovitejs:mainfrom Mar 20, 2021
Shinigami92:pr-template
Merged
chore: provide a pr template#2608patak-cat merged 9 commits intovitejs:mainfrom Shinigami92:pr-template
patak-cat merged 9 commits intovitejs:mainfrom
Shinigami92:pr-template
Conversation
patak-cat
requested changes
Mar 20, 2021
GrygrFlzr
reviewed
Mar 20, 2021
patak-cat
requested changes
Mar 20, 2021
patak-cat
previously approved these changes
Mar 20, 2021
Member
|
@antfu If this looks good to you, I think we could merge it |
antfu
reviewed
Mar 20, 2021
patak-cat
requested changes
Mar 20, 2021
patak-cat
approved these changes
Mar 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123).What is the purpose of this pull request?
Description
This PR template guides contributors while creating new PRs.
The contributor needs to tick some checkboxes and commits this way that they have read it.
Also they are introduced more to provide a more helpful description text that will help reviewers to understand the PR better and therefore stabilize the project.
In addition to that, core members can faster identify if the PR will introduce breaking changes or just add/improve e.g. some documentation
Addition Context
Reviewer focus: