The postcss-import is need process some case like alias, your provider version is lost it. Look like give users some warning is better?

The postcss-import is need process some case like alias, your provider version is lost it. Look like give users some warning is better?

hmm if someone has a custom plugin for resolving @import then imho he would like to opt out from default.

For example, importing json files that would be converted to custom properties @import './lib/css/colors.json'

require('postcss-import')({
  path: ['src'],
  load: loadContentWithJson,
}),

I think it's better to

1. Warn that Vite already includes postcss-import if user provides their own
2. Add css.postcssImportOptions which can be merged into Vite's internal postcss-import options (and mention this in the warning message as well).

Hey @piecyk, would you like to keep this PR open to work in the future point on the suggested changes by Evan? We could create an enhancement issue if not tracking this improvement.

@matias-capeletto Yes.

@yyx990803 Thanks for replay 👍 I think having it other way around would be more flexible, it's more advance case. Would pass the resolve function to postcss config. Similar as in #2436 ( also waiting for review 👋 ) file, and push the responsibility of passing it to postcss-import to user.

Having separate postcss.config and then need to specify in vite config postcssImportOptions would look bit off.

If you still think that postcssImportOptions is the way to go, ping me and I will update the PR.

ping @yyx990803

Hey @piecyk, we are using GitHub's review requests when we need Evan's input so he can look at all the issues and PR that require his attention when he is focusing on Vite. There is no need to explicitly ping him with an extra message.

@piecyk 👋 I currently just wanted to review/reproduce your PR and check if everything is working
But sadly you don't provide a repro right now 🙁
Could you add a repo or at least instructions what to setup for a repro?

Hey @piecyk, we are using GitHub's review requests when we need Evan's input so he can look at all the issues and PR that require his attention when he is focusing on Vite. There is no need to explicitly ping him with an extra message.

Ok, fyi requests was added after i did the ping 🤷‍♂️

@piecyk 👋 I currently just wanted to review/reproduce your PR and check if everything is working
But sadly you don't provide a repro right now 🙁
Could you add a repo or at least instructions what to setup for a repro?

hmm you can checkout branch from this PR https://github.com/piecyk/vite/tree/fix/css/check-for-import-plugin and use the css playground. For example adding the postcss-import to https://github.com/piecyk/vite/blob/fix/css/check-for-import-plugin/packages/playground/css/postcss.config.js