fix: fix early logger definiton in resolveConfig#2425
Merged
yyx990803 merged 1 commit intovitejs:mainfrom Mar 15, 2021
stingalleman:main
Merged
fix: fix early logger definiton in resolveConfig#2425yyx990803 merged 1 commit intovitejs:mainfrom stingalleman:main
yyx990803 merged 1 commit intovitejs:mainfrom
stingalleman:main
Conversation
CHOYSEN
approved these changes
Mar 8, 2021
antfu
approved these changes
Mar 8, 2021
Contributor
Author
|
Hey @antfu, could this be merged (and pushed to npm)? I really need this fixed 😄 |
Member
|
Hey @stingalleman, until Vite is released with these changes, you could use a tool like https://www.npmjs.com/package/patch-package to patch the current version locally and be able to share it with others. |
Contributor
Author
I didn't know tools like these existed. Definitely going to use that. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config was defined too early in resolveConfig.
config.logLevelandconfig.clearScreenboth aren't defined yet, so these options do not work.