test(dynamic-import): cover object rest destructuring of dynamic import#22780
Draft
shulaoda wants to merge 1 commit into
Draft
test(dynamic-import): cover object rest destructuring of dynamic import#22780shulaoda wants to merge 1 commit into
shulaoda wants to merge 1 commit into
Conversation
6aae651 to
d1592ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this solves
Adds a regression test for object rest destructuring of a dynamic import. With the build-time
__vitePreloadrewrite,import('./m').then(({ a, ...rest }) => ...)dropped the sibling exports fromrest(it was nested one level deeper,{ rest: {...} }), silently producing wrong output. The underlying bug and fix are in rolldown: rolldown/rolldown#9976.The new case in
playground/dynamic-importimports a module with several named exports via object-rest destructuring and asserts thatrestkeeps its sibling keys. It fails against the buggy build output and passes once Vite picks up the fixed rolldown.Notes for reviewers
The test exercises the build-mode
__vitePreloadpath (the nativeviteBuildImportAnalysisPluginfromrolldown/experimental). It turns green after the rolldown fix (rolldown/rolldown#9976) is released and therolldowndependency is bumped.