fix(bundled-dev): serve assets emitted during HMR/lazy compile#22745
Merged
Conversation
Member
Author
|
Blocked until rolldown/rolldown#9815 gets released |
245bc43 to
3dfa64d
Compare
27fbbfd to
9a37c5d
Compare
3dfa64d to
9cbaf60
Compare
sapphi-red
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Full Bundle Mode, assets emitted while generating an HMR patch or compiling a lazy entry (e.g. an image newly imported by the changed/lazy module) never reached the dev consumer — those paths skip the generate stage, so they never fire onOutput, the only asset-delivery channel. The browser then 404s the asset until a full reload.
This adds an onAdditionalAssets dev callback that delivers those assets before the patch/lazy code reaches the client, so a consumer that serves built files (Vite) can serve them in time.
Fixes #22596