fix: map css minify warnings to source files#22645
Open
pupuking723 wants to merge 1 commit into
Open
Conversation
860889a to
3c28f2e
Compare
3c28f2e to
9448ae9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Maps esbuild CSS minification warnings back to the CSS source file that contributed the warning location. This makes warnings from merged CSS bundles point at files such as
test.cssinstead of only the generated bundle name likestyle.css.Fixes #15915.
Additional context
The CSS plugin now tracks the line ranges contributed by each CSS module while building CSS chunks. When esbuild reports a warning against the bundled CSS, Vite remaps the warning location before formatting the message.
Validation
npx pnpm@10.34.1 --filter vite buildnpx pnpm@10.34.1 --filter vite typechecknpx pnpm@10.34.1 run typechecknpx pnpm@10.34.1 run test-build playground/minifyoxfmtandeslintpassed for the changed files