fix: apply correct fs restrictions for pnpm gvs#22415
Merged
Merged
Conversation
Member
|
I don't think this addresses what sapphi mentioned here. But we also don't want to run this exec for everyone on every startup. I noticed pnpm saves some metadata in non-gvs: {
"storeDir": "/Users/bjorn/Library/pnpm/store/v11",
"virtualStoreDir": ".pnpm",
"virtualStoreDirMaxLength": 120
}gvs: {
"storeDir": "/Users/bjorn/Library/pnpm/store/v11",
"virtualStoreDir": "../../../../Library/pnpm/store/v11/links",
"virtualStoreDirMaxLength": 120,we could use the path here to pass to the allowlist. |
Contributor
Author
|
This looks good; we don't even need to distinguish whether GVS is running or not. We can directly read the relevant file and retrieve the value of the |
Contributor
Author
|
Normally, the content of a |
bluwy
reviewed
May 20, 2026
bluwy
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #22405