fix: handle rolldown and rollup in resolveRolldownOptions#22034
Closed
florian-lefebvre wants to merge 1 commit into
Closed
fix: handle rolldown and rollup in resolveRolldownOptions#22034florian-lefebvre wants to merge 1 commit into
florian-lefebvre wants to merge 1 commit into
Conversation
Member
|
Vite sets vite/packages/vite/src/node/utils.ts Lines 1252 to 1285 in 0dad284 I guess there's a code that breaks that somewhere. |
Author
|
I just tested quickly and this is because in my reproduction, the whole // doesn't work
builder.environments.client.config.build.rolldownOptions = {
input: 'src/client.js',
output: {
entryFileNames: '__test__',
},
};
// works
builder.environments.client.config.build.rolldownOptions.input =
"src/client.js";
builder.environments.client.config.build.rolldownOptions.output = {
entryFileNames: "__test__",
}; |
Member
|
Since the compat code adds |
Author
|
I unfortunately cannot work on this anymore so I'm going to close it, thanks for the help! At least that's context for anyone working on the linked issue in the future |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rolldownOptionswould not be used to resolve some options during the build, unlikerollupOptions. This PR updates the logic so it first usesrolldownOptionsand fallbacks torollupOptionsindex.htmlwhen mutatingrolldownOptions.input#22033resolveRolldownOptionsis not tested currently