feat(build): chunk importmap#21580
Merged
Merged
Conversation
Co-authored-by: Taisei Mima <bhbstar.me@gmail.com>
2dd9076 to
52e121f
Compare
@vitejs/plugin-legacy
vite
commit: |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
build.chunkImportMapoption, which utilizes import maps feature to optimize chunk caching efficiency.This PR is based on #16552 and uses Rolldown's experimental importmaps feature. Huge thanks to @bhbs who have researched this topic and gave us the insights.
The implementation in the Vite core relies on
import.meta.resolve. For that reason, only browsers withimport.meta.resolvesupport are supported when this option is used.To align with this, plugin-legacy now considers(done in #21662) The plugin-legacy support for this feature is implemented by using the import map support in SystemJS.import.meta.resolveto be "widely-available". In other words, browsers withoutimport.meta.resolvewill use the legacy chunks instead of the modern chunks.Note that
experimental.renderBuiltUrlcurrently does not work with this option. To properly support the combination of that option + this option, it requires more effort to design how to handle absolute URLs (e.g. how to support the case whererenderBuiltUrlreturns an absolute URL that should be mapped by the import map).Also note that this optimization currently does not apply to CSS and assets. But this shouldn't affect largely as it will only invalidate the JS file that is importing them and would not affect the JS files that transitively imports the changed CSS / asset.
fixes #6773
fixes #10636
close #16552