fix(build): avoid redefining viteMetadata on chunk#21470
Closed
Avinash99b wants to merge 1 commit intovitejs:mainfrom
Closed
fix(build): avoid redefining viteMetadata on chunk#21470Avinash99b wants to merge 1 commit intovitejs:mainfrom
Avinash99b wants to merge 1 commit intovitejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the build failure reported in #21466, where Vite 8.0.0-beta.9 crashes during build with:
This occurs when using Nitro/TanStack Start, where the same chunk object may be processed more than once during output normalization with the Rolldown-based pipeline.
Root Cause
injectChunkMetadatapreviously unconditionally defined theviteMetadataproperty on the chunk usingObject.defineProperty. When the function is re-entered for the same chunk, redefining the property throws at runtime.Fix
The metadata injection is now guarded so the property is only defined if it does not already exist. This makes the operation idempotent while preserving existing behavior for builds where chunks are processed only once.
Impact
Closes #21466.