Conversation
patak-cat
commented
Jun 2, 2025
Comment on lines
+268
to
+271
| return ( | ||
| id.startsWith('\0') || | ||
| !deniedServingAccessForTransform(id, server, res, next) | ||
| ) |
Member
Author
There was a problem hiding this comment.
The test will pass without this added check because of the fallback logic added to deniedServingAccessForTransform, but if we know the id is a virtual module, then we can skip the check directly.
patak-cat
commented
Jun 2, 2025
| '', | ||
| ) | ||
| if ( | ||
| !url.startsWith('/@id/\0') && |
Member
Author
There was a problem hiding this comment.
At this point, we have replaced the NULL_BYTE_PLACEHOLDER but didn't yet unwrapped the id. We could actually remove the whole check now that we are doing it before load but leaving that to be done in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #19914
Description
Whitelist virtual modules from fs serving access check