fix(ssr): handle uninitialized export access as undefined#19959
Merged
patak-cat merged 5 commits intovitejs:mainfrom May 2, 2025
Merged
fix(ssr): handle uninitialized export access as undefined#19959patak-cat merged 5 commits intovitejs:mainfrom
patak-cat merged 5 commits intovitejs:mainfrom
Conversation
sheremet-va
previously approved these changes
May 1, 2025
commit: |
9 tasks
Contributor
Author
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI on
✅ analogjs, astro, ladle, histoire, qwik, quasar, react-router, marko, nuxt, vite-environment-examples, rakkas, unocss, sveltekit, vite-plugin-react-swc, vite-plugin-pwa, vite-plugin-react, vite-setup-catalogue, vite-plugin-cloudflare, vite-plugin-svelte, storybook, waku, vuepress, vitepress, vite-plugin-vue |
patak-cat
reviewed
May 2, 2025
packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts
Outdated
Show resolved
Hide resolved
patak-cat
reviewed
May 2, 2025
packages/vite/src/node/ssr/runtime/__tests__/server-runtime.spec.ts
Outdated
Show resolved
Hide resolved
patak-cat
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Export hoisting #18983 made an cyclic import handling to match better with esm (meaning valid cyclic imports are accepted and invalid ones are correctly rejected), but it turns out to be too strict for Vitest users which tends to import arbitrary files as first entry. The behavior change was too drastic for the patch release 6.3.3 at least, so in this PR, I added
try/catchto make invalid exports to be fallback toundefined. Note that this should still make valid cyclic imports to work, which was the original motivation of #18983.I confirmed provided reproductions are fixed with pr package (except there is a case like #19929 (comment), which is due to another fix #19841, so they are still expected to be addressed on user side).
On Vitest side, there might be more complicated scenarios with mocking, so I couldn't actually tell whether it's an cyclic imports issues. We'll revisit whether we should remove
try/catchafter investigating that further.