fix(css): avoid using default export from sass-embedded#19053
fix(css): avoid using default export from sass-embedded#19053cod1r wants to merge 3 commits intovitejs:mainfrom
Conversation
sapphi-red
left a comment
There was a problem hiding this comment.
While I wasn't able to reproduce it, the default export seems to be deprecated, so I think we should avoid using it anyways.
https://sass-lang.com/documentation/breaking-changes/default-export/
|
You most likely need to have sass-embedded installed first; but yay... |
|
There was a similar issue in #17880. As I commented in the previous PR, references
I still have no idea why |
commit: |
|
I might be wrong but the code I changed is in a function that is only called if the sassPackage is https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/css.ts#L2575 |
|
the code that handles the specific |
|
|
I added a conditional check. Maybe that fixes this situation a little better? |
fixes #19052
I pray that this doesn't mess anything else up :)