Run & review this pull request in StackBlitz Codeflow.

Would it also be relevant to cast the actual error being thrown in https://github.com/vitejs/vite/blob/main/packages/vite/src/node/plugins/importAnalysisBuild.ts#L148

Doing something like this in the importAnalysisBuild.ts file:

const e: VitePreloadErrorEvent = new Event('vite:preloadError', { cancelable: true })
e.payload = err
window.dispatchEvent(e)
if (!e.defaultPrevented) {
    throw err
}

I think that will also make it possible to remove the // @ts-expect-error comment

As @MathiasWP said, do you think we need to customize a VitePreloadErrorEvent type to remove ts comments? @bluwy

As @MathiasWP said, do you think we need to customize a VitePreloadErrorEvent type to remove ts comments? @bluwy

If it's possible to cast then that would be great, but I don't know if there's complications doing that when the types come from client.d.ts. I don't mind if not either.

The type is not complicated, it is simpler to just declare one.

Feedback for whoever, in typescript this makes is more complicated to spyOn as there is now a colliding overload.