feat: decouple DevEnvironment and server#16460
Merged
patak-cat merged 10 commits intofeat/environment-apifrom Apr 19, 2024
Merged
feat: decouple DevEnvironment and server#16460patak-cat merged 10 commits intofeat/environment-apifrom
patak-cat merged 10 commits intofeat/environment-apifrom
Conversation
|
|
sheremet-va
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ViteDevServeris no longer needed to create aDevEnvironment. This triggered a lot of changes totransformRequestand related functionsenvironment.init()ScanEnvironment, used in the optimizer scanner{ split(environment) { return MyPlugin(environment) }. We need a better name forsplit. Just a placeholder for now.Start work to move fallback logic in transformRequest to a plugin. I reverted the change for now (leaving the code). We can check this in a future PR.