Skip to content

fix(css): skip url replace for function calls#15544

Merged
bluwy merged 2 commits intovitejs:mainfrom
smeng9:fix-scss-url-function
Jan 10, 2024
Merged

fix(css): skip url replace for function calls#15544
bluwy merged 2 commits intovitejs:mainfrom
smeng9:fix-scss-url-function

Conversation

@smeng9
Copy link
Contributor

@smeng9 smeng9 commented Jan 9, 2024 •
edited
Loading

Description

Closes #10473

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Jan 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-cat patak-cat added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 9, 2024
@bluwy bluwy changed the title fix(css): sass failed to skip resolving function call in url() fix(css): skip url replace for function calls Jan 10, 2024
@bluwy bluwy merged commit 21a52e6 into vitejs:main Jan 10, 2024
@smeng9 smeng9 deleted the fix-scss-url-function branch January 10, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

feat: css p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[vite-url-rewrite] messes up url(), when the url contains a single function call with Scss

3 participants

@smeng9 @patak-cat @bluwy