fix(assets): avoid splitting , inside base64 value of srcset attribute#15422
Merged
sapphi-red merged 7 commits intovitejs:mainfrom Dec 30, 2023
Merged
fix(assets): avoid splitting , inside base64 value of srcset attribute#15422sapphi-red merged 7 commits intovitejs:mainfrom
, inside base64 value of srcset attribute#15422sapphi-red merged 7 commits intovitejs:mainfrom
Conversation
|
|
, inside base64 value within srcset attribute of img, inside base64 value within srcset attribute of img
, inside base64 value within srcset attribute of img, inside base64 value within srcset attribute of img
bluwy
reviewed
Dec 26, 2023
, inside base64 value within srcset attribute of img, inside base64 value of srcset attribute
rubiin
approved these changes
Dec 27, 2023
sapphi-red
approved these changes
Dec 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15419
Description
As mentioned in the issue, when parsing
srcset, the,inside base64 value was getting split and joined again, breaking the base64 encoding.The comment of
splitSrcSetsays that it is handling"data:..."case. But RE itself is only catching single or double quotes. I added additional RE logic to capture the whole base64 values.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).