Skip to content

fix(hmr): make watcher ignore build.outDir#15326

Merged
patak-cat merged 4 commits intovitejs:mainfrom
nozomuikuta:fix/watch-out-dir
Jan 9, 2024
Merged

fix(hmr): make watcher ignore build.outDir#15326
patak-cat merged 4 commits intovitejs:mainfrom
nozomuikuta:fix/watch-out-dir

Conversation

@nozomuikuta
Copy link
Contributor

@nozomuikuta nozomuikuta commented Dec 12, 2023

Description

Resolves #15241
I just added build.outDir to Chokidar's ignored option.

Additional context

This is my very first PR to Vite, so I might be missing something important.
Please be careful.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

I guess watching build.outDir is unexpected, so it's a bug.

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

I'm not sure how to unit-test this PR.
I confirmed that this PR resolves the original issue by following reproduction steps of it.

@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Dec 12, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-cat patak-cat added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 12, 2023
@patak-cat
Copy link
Member

patak-cat commented Dec 12, 2023

Thanks for the PR @nozomuikuta! I'll add this one to the team board for discussion. If we merge it, we will be doing it as part of the next minor (we may take a few weeks to answer because of the holiday season).

@patak-cat patak-cat added this to the 5.1 milestone Dec 12, 2023
bluwy
bluwy previously approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see a reason to not ignore it.

@nozomuikuta nozomuikuta requested a review from bluwy December 21, 2023 15:24
patak-cat
patak-cat previously approved these changes Jan 8, 2024
View reviewed changes
@nozomuikuta nozomuikuta dismissed stale reviews from patak-cat and bluwy via d152d82 January 9, 2024 01:01
@nozomuikuta
Copy link
Contributor Author

nozomuikuta commented Jan 9, 2024

@patak-dev

Thank you for approving the PR!

I found this PR came to conflict with the latest main branch so resolved it.
Would you check the code again just in case?

By the way, is it fine to close #15326 (comment) without applying the change?

@nozomuikuta nozomuikuta requested a review from patak-cat January 9, 2024 01:06
@patak-cat
Copy link
Member

patak-cat commented Jan 9, 2024

@nozomuikuta I think you should commit your proposed change at https://github.com/vitejs/vite/pull/15326/files#r1434206818 👍🏼

@nozomuikuta
Copy link
Contributor Author

nozomuikuta commented Jan 9, 2024

@patak-dev

Committed it and resolved the conversation! 🚀

@patak-cat patak-cat merged commit 2836276 into vitejs:main Jan 9, 2024
@nozomuikuta nozomuikuta deleted the fix/watch-out-dir branch January 9, 2024 08:37
@jedso jedso mentioned this pull request Mar 24, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

Team Board
Archived in project

Milestone

5.1

Development

Successfully merging this pull request may close these issues.

outDir not ignored in watched files

3 participants

@nozomuikuta @patak-cat @bluwy