Skip to content

fix: json error with position#15225

Merged
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/json-error-with-position
Dec 4, 2023
Merged

fix: json error with position#15225
patak-cat merged 1 commit intovitejs:mainfrom
sapphi-red:fix/json-error-with-position

Conversation

@sapphi-red
Copy link
Member

Description

A code to show better JSON parse error existed but was not working. This PR fixes that code and adds a code to handle "Unexpected end of JSON input" error as well.

Before

[plugin:vite:json] Failed to parse JSON file, invalid JSON syntax found at line 19
D:/documents/GitHub/vite/playground/define/data.json

After

[plugin:vite:json] Failed to parse JSON file, invalid JSON syntax found at position 18
D:/documents/GitHub/vite/playground/define/data.json:2:17
1  |  {
2  |    "foo": "__EXP__
   |                  ^
3  |  }
4  |

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-nice-to-have Not breaking anything but nice to have (priority) label Dec 3, 2023
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@patak-cat patak-cat merged commit 14be75f into vitejs:main Dec 4, 2023
@sapphi-red sapphi-red deleted the fix/json-error-with-position branch December 4, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants