Skip to content

feat: add '*.mov' to client.d.ts#15189

Merged
patak-cat merged 2 commits intovitejs:mainfrom
bogxi:patch-1
Dec 4, 2023
Merged

feat: add '*.mov' to client.d.ts#15189
patak-cat merged 2 commits intovitejs:mainfrom
bogxi:patch-1

Conversation

@bogxi
Copy link
Contributor

@bogxi bogxi commented Nov 29, 2023

fix #15183

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-cat patak-cat changed the title Update client.d.ts - add '*.mov' feat: add '*.mov' to client.d.ts Nov 29, 2023
patak-cat
patak-cat previously approved these changes Nov 29, 2023
@bluwy
Copy link
Member

bluwy commented Nov 30, 2023

I think we also need to add it here:

// media
'mp4',
'webm',
'ogg',
'mp3',
'wav',
'flac',
'aac',
'opus',

@patak-cat patak-cat dismissed their stale review November 30, 2023 07:42

Thanks Bjorn! 🙏

@bogxi
Copy link
Contributor Author

bogxi commented Dec 4, 2023

Thanks @bluwy. Sorry for the delay.
I was able to apply the change and update the pr.
@patak-dev I think we're ready now :)

P.S. This is my first contribution to open source 🙌🏼
Thank you Vite.js team for the amazing work 🔥

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Copy link
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @jorge-ui!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing media module '*.mov'

3 participants