build: handle latest json-stable-stringify replacement#15049
Merged
bluwy merged 1 commit intovitejs:mainfrom Nov 22, 2023
Merged
build: handle latest json-stable-stringify replacement#15049bluwy merged 1 commit intovitejs:mainfrom
bluwy merged 1 commit intovitejs:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the recent version (
v1.1.0) of thejson-stable-stringifymodule, caching ofJSON.stringifywas implemented.The syntax changed from:
to:
Vite optimized the
json-stable-stringifymodule and in its transform phase it matched a regular expression for thejsonifymodule, which caused build failures due to changes in syntax.The original regex pattern was:
/^var json = typeof JSON.+require\('jsonify'\);$/gmI personally think that there is no need to consider how the submodule of itself is dependent on by the
json-stable-stringfymodule, just replacing its own submodule withJSONcan achieve expectations.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).