fix(esbuild): set js loader for build transpile#14980
Merged
Conversation
patak-cat
approved these changes
Nov 14, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
We'll be accepting not having a .js extension for chunks as a feature after merging this PR, and maybe we should keep it more strict. I like this as an optimization though. We aren't documenting a change so lets merge the PR, we could later still decide to force a js extension if we have good reasons to do it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #10147
Since
renderChunkshould always only deal with JS files, we can setloader: 'js'as an optimization, and also fix #10147 so it doesn't have to detect the extension manually.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).