Skip to content

refactor!: remove https flag#14681

Merged
patak-cat merged 3 commits intovitejs:mainfrom
sapphi-red:refactor/remove-https-flag
Oct 18, 2023
Merged

refactor!: remove https flag#14681
patak-cat merged 3 commits intovitejs:mainfrom
sapphi-red:refactor/remove-https-flag

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 18, 2023

Description

#14621 (comment)

fix #10058

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red requested a review from bluwy October 18, 2023 08:38
@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) breaking change labels Oct 18, 2023
@sapphi-red sapphi-red added this to the 5.0 milestone Oct 18, 2023
@sapphi-red sapphi-red marked this pull request as ready for review October 18, 2023 08:51
patak-cat
patak-cat previously approved these changes Oct 18, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERR_SSL_VERSION_OR_CIPHER_MISMATCH when both --https and server.https provided

3 participants