Skip to content

fix(manifest): include assets referenced in html#14657

Merged
bluwy merged 1 commit intomainfrom
arnaud/fix-manifest
Oct 18, 2023
Merged

fix(manifest): include assets referenced in html#14657
bluwy merged 1 commit intomainfrom
arnaud/fix-manifest

Conversation

@ArnaudBarre
Copy link
Member

@ArnaudBarre ArnaudBarre commented Oct 16, 2023

Discovered by hasard while doing #14643 (required to make tests pass)

@ArnaudBarre ArnaudBarre self-assigned this Oct 16, 2023
@ArnaudBarre ArnaudBarre mentioned this pull request Oct 16, 2023
Merged
@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Oct 17, 2023
sapphi-red
sapphi-red reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@sapphi-red sapphi-red left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Would you add a test here that ensures the asset only referenced in html is included in the manifest?

vite/playground/assets/__tests__/assets.spec.ts

Lines 413 to 424 in 96a4ce3

test.runIf(isBuild)('manifest', async () => {
const manifest = readManifest('foo')
const entry = manifest['index.html']
for (const file of listAssets('foo')) {
if (file.endsWith('.css')) {
expect(entry.css).toContain(`assets/${file}`)
} else if (!file.endsWith('.js')) {
expect(entry.assets).toContain(`assets/${file}`)
}
}
})

bluwy
bluwy reviewed Oct 17, 2023
View reviewed changes
playground/assets/nested/html-only-asset.jpg
Copy link
Member

@bluwy bluwy Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny nit: could we use an svg so it's smaller?

Copy link
Member Author

@ArnaudBarre ArnaudBarre Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My next PR will make SVG be inline.
But I can use a new SVG and reduce the inlineSize now, but this requires a new config test because the default one is already increase to 8kb (why I used ~12kb one)

Copy link
Member

@bluwy bluwy Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok if it's specifically to pass the 8kb limit, and there's no existing files to use I'm fine with it then. No need to change 👍

@ArnaudBarre
Copy link
Member Author

ArnaudBarre commented Oct 17, 2023

@sapphi-red you're suggesting adding a new test with a html + asset file only and duplicate this test?
The linked test is actually failing with the playground change without the code

@sapphi-red
Copy link
Member

sapphi-red commented Oct 17, 2023

My bad, I misunderstood the test.

@bluwy bluwy merged commit f627b91 into main Oct 18, 2023
@bluwy bluwy deleted the arnaud/fix-manifest branch October 18, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bluwy bluwy bluwy approved these changes

@sapphi-red sapphi-red sapphi-red approved these changes

@patak-cat patak-cat Awaiting requested review from patak-cat

Assignees

@ArnaudBarre ArnaudBarre

Labels

p3-minor-bug An edge case that only affects very specific usage (priority)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ArnaudBarre @sapphi-red @bluwy