Skip to content

feat!: add extension to internal virtual modules#14231

Merged
sapphi-red merged 2 commits intovitejs:mainfrom
sapphi-red:feat/add-extension-to-internal-virtual-modules
Sep 15, 2023
Merged

feat!: add extension to internal virtual modules#14231
sapphi-red merged 2 commits intovitejs:mainfrom
sapphi-red:feat/add-extension-to-internal-virtual-modules

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Aug 29, 2023

Description

Adds the extension (.js) to internal virtual modules (e.g. vite/modulepreload-polyfill)

close #9016

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added rollup plugin compat p2-nice-to-have Not breaking anything but nice to have (priority) breaking change labels Aug 29, 2023
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Aug 29, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-cat
patak-cat approved these changes Aug 29, 2023
View reviewed changes
Copy link
Member

@patak-cat patak-cat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is a good idea to wait until ecosystem-ci is green to be able to do a run with this PR properly.

@sapphi-red sapphi-red added this to the 5.0 milestone Aug 31, 2023
@sapphi-red
Copy link
Member Author

sapphi-red commented Sep 14, 2023

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Sep 14, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ❌ failure
ladle ❌ failure
laravel ✅ success
marko ✅ success
nuxt ❌ failure
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ✅ success
vite-plugin-pwa ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ❌ failure
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

@sapphi-red
Copy link
Member Author

sapphi-red commented Sep 14, 2023

I guess nuxt is failing because of this line: https://github.com/nuxt/nuxt/blob/f000e8b605c3702882310ee7b3925233c83ace98/packages/vite/src/plugins/chunk-error.ts#L8

Other fails are the same with the main branch.

@sapphi-red sapphi-red requested a review from bluwy September 15, 2023 05:39
@sapphi-red sapphi-red merged commit 9594c70 into vitejs:main Sep 15, 2023
@sapphi-red sapphi-red mentioned this pull request Sep 15, 2023
Merged
8 tasks
@sapphi-red sapphi-red deleted the feat/add-extension-to-internal-virtual-modules branch September 15, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

breaking change p2-nice-to-have Not breaking anything but nice to have (priority) rollup plugin compat

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

Preload code not passing through rollup

3 participants

@sapphi-red @patak-cat @bluwy