fix: revert import config module as data#13731
Conversation
|
|
|
Done, thanks @silverwind! |
|
Thanks, could you also unlock the discussions in them? |
|
I'm sorry for the situation, let's find a better way |
|
Dont worry @s10y10, it was good we tried the approach. |
|
I think the revert was premature, the issue should have been analyzed at least. #13730 did not provide a reproduction, so we will never know what the actual issue was (strictly speaking, the issue is invalid because it has no reproduction). Maybe the URL was somehow incorrectly encoded, e.g. stuff that good test coverage can catch. |
|
@silverwind I think the revert was valid here, we weren't sure this approach was safe and it failed as soon as we released it, and seems the issue is on our side. We can try with more time again. I hope @cpojer could provide a minimal reproduction to help you test a new take at it. |
Description
Fixes #13730. See issue for description. If we want to move forward with using
data:text/javascript, we would need to consider more edge cases. I think reverting is the best move right now.What is the purpose of this pull request?