fix: transform error message add file info#13687
Merged
bluwy merged 5 commits intovitejs:mainfrom Jul 17, 2023
Merged
Conversation
|
|
Member
|
IIUC the original issue had this error: Would this only append the file path to that error? I feel like the core issue is that we're cutting off additional information in that error that we shouldn't, so we can fix that instead of adding the |
Contributor
Author
Member
|
Thanks. In that case I'm ok with patching this specific case for now then. Could we perhaps narrow down to the So the file paths follow nicely after the "read". |
Contributor
Author
Member
|
Thanks. Could we also only add the error message when |
Contributor
Author
Yeah, this should be better. |
bluwy
reviewed
Jul 17, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
approved these changes
Jul 17, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
fix #13439
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).