fix(importMetaGlob): avoid unnecessary hmr of negative glob#13646
Merged
patak-cat merged 4 commits intovitejs:mainfrom Jul 28, 2023
Merged
fix(importMetaGlob): avoid unnecessary hmr of negative glob#13646patak-cat merged 4 commits intovitejs:mainfrom
patak-cat merged 4 commits intovitejs:mainfrom
Conversation
|
|
sapphi-red
reviewed
Jul 24, 2023
sapphi-red
reviewed
Jul 26, 2023
| allGlobs.some( | ||
| ({ affirmed, negated }) => | ||
| affirmed.some((glob) => isMatch(file, glob)) && | ||
| negated.every((glob) => !isMatch(file, glob)), |
Member
There was a problem hiding this comment.
Suggested change
| negated.every((glob) => !isMatch(file, glob)), | |
| negated.every((glob) => isMatch(file, glob)), |
I think this ! should be removed. I initially made this mistake but corrected in #13646 (comment).
For example, if negated is ['!foo.js', '!bar.js'], then isMatch('baz.js', glob) will return true for all of them.
Member
Author
There was a problem hiding this comment.
Ah I see.
This remind me that code below maybe more robust ?
(!affirmed.length || affirmed.some((glob) => isMatch(file, glob))) &&
(!negated.length || negated.every((glob) => isMatch(file, glob)))
Member
|
/ecosystem-ci run |
|
📝 Ran ecosystem CI: Open
|
patak-cat
approved these changes
Jul 28, 2023
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #13374
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).