fix(optimized-deps-build): avoid deadlock when loading register id and optimized id#13127
Closed
sun0day wants to merge 1 commit intovitejs:mainfrom
Closed
fix(optimized-deps-build): avoid deadlock when loading register id and optimized id#13127sun0day wants to merge 1 commit intovitejs:mainfrom
sun0day wants to merge 1 commit intovitejs:mainfrom
Conversation
…id and optimized id
|
|
Member
|
Let's wait to see how rollup/rollup#4985 evolves. Given that the feature is experimental, users may better bump |
4 tasks
Member
|
Closing as the build-time dep-optimization is now removed (#15184). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #13018
Calling
load(id)hook onregisterIdandoptimizedIdare currently async, this might lead to a deadlock.The
loadtask queue would be like[loadRegisterId1, loadOptimizedId, loadRegisterId2]according tohttps://github.com/rollup/rollup/blob/742317579d7ca861047fa8320631c7e061f98c02/src/ModuleLoader.ts#L261-L263
https://github.com/rollup/rollup/blob/742317579d7ca861047fa8320631c7e061f98c02/src/utils/Queue.ts#L17-L40
loadOptimizedIdshould wait until all theloadRegisterIdtasks finish, but it's called beforeloadRegisterId2, thusloadOptimizedIdwould never be resolved.This PR make sure
optimizedIdis loaded after all theloadRegisterIdfinish.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).