fix(define): incorrect raw expression value type in build#13003
Merged
bluwy merged 1 commit intovitejs:mainfrom Apr 30, 2023
Merged
fix(define): incorrect raw expression value type in build#13003bluwy merged 1 commit intovitejs:mainfrom
bluwy merged 1 commit intovitejs:mainfrom
Conversation
|
|
patak-cat
approved these changes
Apr 25, 2023
bluwy
approved these changes
Apr 30, 2023
Member
bluwy
left a comment
There was a problem hiding this comment.
Thanks for fixing this, I must've overlooked this before. I think if we want to further optimize this, we could perhaps reuse the serailizeDefine function in clientInjections.ts to avoid the regexes.
9 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix #12866
{ "define": { "import.meta.env.RAW_IDENTIFIER": "raw_id", "import.meta.env.RAW_EXPRESSION": "123", "import.meta.env.STRING": "\"123\"" } }Before PR:
import.meta.envin build mode:After PR:
import.meta.envin build mode:Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).