perf(optimizer): bulk optimizer delay#12609
Merged
patak-cat merged 1 commit intovitejs:mainfrom Mar 27, 2023
Merged
Conversation
|
|
patak-cat
reviewed
Mar 27, 2023
| registeredIds.length > 0 || | ||
| results.some((result) => result.status === 'rejected') | ||
| ) { | ||
| afterLoad() |
Member
There was a problem hiding this comment.
The setTimeout 0 here was added at the time because things were failing if we did a direct call. It may have been a bug that prevented us to do it. I think we can try it out without it now, let's keep in mind that we could add it later here if needed (I don't think it would affect perf)
patak-cat
approved these changes
Mar 27, 2023
Member
patak-cat
left a comment
There was a problem hiding this comment.
It is incredible how much of a difference this makes. Awesome catch @sapphi-red! 🔥
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
runOptimizerWhenIdlewas called many times.Also it was called serially every time waiting for
.done()to be completed.This PR reduces
runOptimizerWhenIdleby calling multiple.done()in a singlerunOptimizerWhenIdlecall. Also this PR calls.done()parallelly.I ran this PR on https://github.com/sapphi-red/performance-compare/tree/65d51a32b0282593f1b75def25075a02b28f6397.
Without this PR (
420782c76733ecc8314bccc2255976347add3d2e), start up time (with--force) was 16422ms with plugin-react.With the PR, start up time was 4784ms. This is about 3.4x improvement.
I guess this improves performance if there's many files.
More detailed result of the benchmark: https://gist.github.com/sapphi-red/d1ee341566a052703732238788cb0447
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).