Conversation
|
|
Member
|
Nice! Looks good to me. Added the PR to the team board with P2-5 so we get to it in the next meeting. |
Liknox
previously approved these changes
Mar 17, 2023
Member
Author
|
Added docs and mention that it's experimental. Should be good now. |
4 tasks
Member
Author
|
The CI fail seems to be flaky and unrelated as it happens for other PRs too. It likely happen more often since #13413 (even though the PR is a good refactor). I'm thinking we could merge this for now and tackle that separately (which I'm checking now). Alas I can't merge without an approving review 😅 |
patak-cat
approved these changes
Jun 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #5419
Support
optimizeDeps.include: ['some-pkg/**/*', 'another-pkg/*.js', ...]syntax. While the user could glob themselves, this PR also handles the complex logic of globbing packages withexports.Besides the issue above, I had found in Svelte land where this could be useful for component libraries that heavily rely on deep imports. Being able to optimize all deep imports at once would be helpful.
Additional context
The test could be a lot more complete, but it got a minimum to start with
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).