Run & review this pull request in StackBlitz Codeflow.

It's really a shame we can't call this command as it's quite confusing to have command be 'build'|'serve' and they feel a bit swapped. I wonder if we should name this new one cmd and deprecate the old command?

It's really a shame we can't call this command as it's quite confusing to have command be 'build'|'serve' and they feel a bit swapped.

Yes, I couldn't agree more.

I wonder if we should name this new one cmd

👍 Done.

and deprecate the old command?

I think so too. How about we already start showing a warning in the next patch release?

I noticed that this change is a breaking change as it requires users to pass an additional argument to resolveConfig/loadConfigFromFile. We can avoid that by making the argument optional, but I fear that would lead to a same situation with configEnv.ssrBuild (#13809).

We discussed about this in the meeting today. To minimize the changes, and since the main usecase is to only differentiate dev and preview, we think passing a isPreview property to ConfigEnv (the second param of the config hook) should be enough for now. resolveConfig can accept a new parameter to pass in the isPreview value.

This would make it work similar to the ssrBuild value today. ssrBuild is used to differentiate what kind of build is running, and isPreview would be used to differentiate what kind of server is running.

Neat, good idea. I'll try to update the PR later today.

@brillout I've already opened a PR 😬 #14855

I forgot to credit you as a co-author for kicking this off though. Let me send a comment there so we do so before merging.

Neat. No need for credits.