fix(worker): force rollup to build worker module under watch mode#11919
Merged
bluwy merged 1 commit intovitejs:mainfrom Mar 12, 2023
Merged
fix(worker): force rollup to build worker module under watch mode#11919bluwy merged 1 commit intovitejs:mainfrom
bluwy merged 1 commit intovitejs:mainfrom
Conversation
d9be8a9 to
9c56e4c
Compare
sapphi-red
approved these changes
Mar 12, 2023
Member
sapphi-red
left a comment
There was a problem hiding this comment.
Thanks!
This doesn't seem to work when editing playground/worker/sub-worker.js. But I think that can be tackled in a different PR.
bluwy
approved these changes
Mar 12, 2023
7 tasks
7 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #8172
fix #11786
close superseds #8700
In build watch mode, the
transformhook will not be called after the load hook ofvite:workerplugin except in the very first build. So useshouldtransformcachedmodulehook to indicate re-call transform hook in watch build mode.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).